Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ports)!: rustup, rust, cargobi #36

Merged
merged 21 commits into from
Feb 9, 2024
Merged

feat(ports)!: rustup, rust, cargobi #36

merged 21 commits into from
Feb 9, 2024

Conversation

Yohe-Am
Copy link
Contributor

@Yohe-Am Yohe-Am commented Jan 24, 2024

This adds support for the rust toolchain through rustup. It also adds a dedicated cargo binstall port in the form of pipi/npmi that supports fallback to building using a rust toolchain if cargo-binstall is unable to locate built versions of the crate.

Motivation and context

This was an obvious missing piece in ghjk. Some targets, like arm, sometimes don't have binary distributions that cargo-binstall is able to locate which resulted broken CI runs.

Migration notes

Users of wasm-opt, wasm-tools, whiz and cargo-insta ports should now use the cargobi port.

install(
  cargobi({ crateName: 'whiz' })
)

Checklist

  • The change come with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

@Yohe-Am Yohe-Am requested a review from zifeo January 24, 2024 08:24
ports/mod.ts Show resolved Hide resolved
Copy link
Member

@zifeo zifeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏

Copy link
Member

@zifeo zifeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Yohe-Am Yohe-Am requested a review from zifeo February 9, 2024 03:50
@Yohe-Am Yohe-Am merged commit 90ac4b3 into main Feb 9, 2024
7 checks passed
@Yohe-Am Yohe-Am deleted the feat/rust branch February 9, 2024 14:00
@Yohe-Am Yohe-Am mentioned this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants